Skip to content

Fix webpack config to account for `NO_SOURCEMAPS=false`

Mike Greiling requested to merge mg-fix-sourcemaps-env into master

What does this MR do?

A recent update to the GDK adds the NO_SOURCEMAPS environment variable to the Procfile based on config in gdk.yml. The NO_SOURCEMAPS environment variable will now be provided regardless of whether it was enabled or disabled, but the webpack config was relying on the mere existence of this variable to disable sourcemaps. So NO_SOURCEMAPS=false was treated the same as NO_SOURCEMAPS=true. This fixes this behavior for multiple environment variables within webpack.config.js to explicitly handle cases where "false" is provided.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading