Fix webpack config to account for `NO_SOURCEMAPS=false`
What does this MR do?
A recent update to the GDK adds the NO_SOURCEMAPS
environment variable to the Procfile based on config in gdk.yml
. The NO_SOURCEMAPS
environment variable will now be provided regardless of whether it was enabled or disabled, but the webpack config was relying on the mere existence of this variable to disable sourcemaps. So NO_SOURCEMAPS=false
was treated the same as NO_SOURCEMAPS=true
. This fixes this behavior for multiple environment variables within webpack.config.js to explicitly handle cases where "false" is provided.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team