Skip to content

Fix error in resource_events tables while deleting user

What does this MR do?

While investigating why user is not deleted while destroying an account, I discovered bug in Sentry - in resource events tables (4 of them) we are setting that user_id cannot be NULL, but in foreign key we are setting ON DELETE NULLIFY. This is causing an error.

Instead I added switching to ghost user id while deleting user.

Screenshots

https://sentry.gitlab.net/gitlab/gitlabcom/issues/1635101/?query=is%3Aunresolved%20DeleteUserWorker

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading