Remove create issue service dependency from create alert issue service
What does this MR do?
Contributes to #217576 (closed)
Copies (mostly) implementation of IncidentManagement::CreateIssueService.
That's removes CreateIssueService as being a dependency for AlertManagement::CreateAlertIssueService.
That that opens possibility to extract more parts from the implementation, for example extracting alert issue presenters, to separate code for "create issue" from "present alert".
That's not an ideal solution, it contains duplication but that's a first step. Which helps to keep MR smaller. In the following MRs, I am going to extract alert presentation code into separate classes.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
~~Label as security and @ mention @gitlab-com/gl-security/appsec~~ -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team