Add validation for docker tag names in job.image.name and job.service[].name.
What does this MR do?
This merge request implements docker docker image name validation through a regex: https://regex101.com/r/HaqLc3/3 - you can check the regex match test suite at https://regex101.com/r/HaqLc3/3/tests
The regex is based on the docker image tag spec as available here
This MR fixes one part of #220915 on the server side
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines As this MR introduces a (slightly complicated) regex, this would need some eyes from your experts on that part. -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
Risks:
- This is a slightly complicated regex, but with a limited amount of backtracking as far as I can see.
- (some) additional performance is required for validating ci config files.
Additional tests to check the new validator can be added.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
N/A
Edited by Fabio Pitino