Skip to content

Block invalid urls in metrics dashboard links

Kirstie Cook requested to merge 219074-safe-link-validation into master

What does this MR do?

We currently validate the urls on the frontend with isSafeUrl (see discussion) but this adds an extra validation step on the backend when processing the dashboards to send to the frontend as an extra layer of security.

See #219074 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading