Skip to content

Docs - add prerequisite for auth approval on MR

Anton Smith requested to merge docs/add-prerequisite-auth-approval-mr into master

What does this MR do?

According to the source code project.rb#L468-470, the require authentication when approving a merge request feature requires the password_authentication_enabled_for_web boolean to be true, which is set in the application settings under sign-in restrictions.

If password_authentication_enabled_for_web is false, then the require authentication when approving a merge request option is not visible in the project settings, which leads to confusion as users expect this option to be there and don't know why it isn't there.

This requirement for password_authentication_enabled_for_web to be true is not in our documentation, so I've added it.

Related issues

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Mike Jang

Merge request reports

Loading