Resolve "Explore removing dependencies on test stage"
What does this MR do?
code_quality
and license_scanning
run after the build
stage, but did not use anything from the build
stage.
So the improvements here are
-
code_quality
now will run immediately, allowing a fail fast for the static code analysis like rubocop. -
license_scanning
which takes about 13 minutes(on internal application) will now run immediately as well, where before it only ran after thebuild
stage.
So in essence we'll get notified earlier of static code analysis/linting issues and improve the over all CI pipeline duration time by about 8 minutes.
This time saving will lessen developer context switching due to getting feedback quicker.
Note: This has been already implemented in the version application here.
Screenshots
Snapshot of jobs above now running immediately:
Before snapshot of duration:
After snapshot of duration:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Contributes to #222358