RUN AS-IF-FOSS: Move CI secrets json schema validation to FOSS
What does this MR do?
With !34480 (merged) we introduced new jsonb column to store CI secrets configuration. Because this is GitLab Premium feature validation was done in EE only which caused test failure for FOSS - #223195 (closed).
This moves validation to app/models/ci/build_metadata.rb, we already had to have the json schema under app/validators/json_schemas/
anyway.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #223195 (closed)
Edited by Nick Thomas