Keep NaN values in data series
Background
Not all data is perfect.
When we pass data to our charts, we ensure to validate the data has no NaN values before getting the charts to display, however, missing points (like NaN) are also valuable information for users, as missing data can convey that an issue must be addressed.
echarts provides a way to display missing data points in a line, and we should do the same, so our charts are more powerful in representing problems in the data displayed:
What does this MR do?
Part of #220760 (closed).
This MR prevents the removal of NaN values in our charts, so missing data points are available. As far as I know, the original motivation for this, was to prevent the legend from showing "NaN" so I adressed the root of the problem at: gitlab-ui!1513 (merged)
Does this change the feature?
Not much. Prometheus may return NaN values as per their documentation, but they occurs only in some special cases, no important changes in the UX are expected yet.
Moving forward, we should process the Prometheus data to add empty/missing values so the line actually show "holes". This will be done in the follow up MR.
Screenshots
N/A.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #223790 (closed)