Apply filter bar values to api requests
What does this MR do?
- Adds additional filter parameters to the
cycleAnalyticsRequestParams
getter - Applies the additional filter parameters to the value stream analytics api requests
NOTE: this requires the changes in !34598 (merged)
Feature flag
You will need to enable the value_stream_analytics_filter_bar
to view the filter bar.
Testing instructions
The filter bar requires the value_stream_analytics_filter_bar
feature flag and only applies to group level VSA (currently not project level)
- Navigate to any group ie
/gruops/gitlab-org
- From the left side bar Navigate to
Analytics
>Value stream analytics
- Select a project from the dropdown, then the filter bar can be tested
- The query parameters should be updated to reflect your selection, and api requests sent
- After adding some parameters, copy the url and open it in a new tab, the filter bar should be returned to the same state
Note:
- The disabled state for the filter bar isnt correctly reflected, but will be fixed
Screenshots
No visual changes
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #217943 (closed)
Edited by Ezekiel Kigbo