Add scanner column to the project-level security dashboard and pipeline security tab
What does this MR do?
The first commit was originally reviewed and merged in !31775 (merged), but had to be reverted due to introducing/exacerbating a couple of bugs. I have brought it back in now and tweaked it/added tests to solve all the issues
My commit does the following: Add scanner column to the project-level security dashboard and pipeline security tab to show report type
- update display values to be human readable
- add utility function to convert report types
- conditionally show the report type column on the project-level security dashboard and not on the group/instance-level security dashboards
- add tests
How to test
$1956676
Screenshots
Pipeline has it
Slightly updated with another MR that got in.
Project-level security dashboard has it
project_security_dashboard_720p
Group/Instance-level do not have it
instance_security_dashboard_no_scanner_720p
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #210327 (closed)