Skip to content

Geo Settings Form - Fetch Data from API

Zack Cuddy requested to merge 216134_03-add-geo-settings-api into master

What does this MR do?

This MR is work towards #216134 (closed)

This MR is an attempt at MVC to avoid the above massive MR going in all at once.

This MR is built behind the feature flag :enable_geo_settings_form_js

This MR hooks up the RESTful API to fetch the application settings data for Geo.

This MR does not add any validations or save actions. It strictly hooks up the Vuex store and data fetching actions to be used in the future MRs.

Breakdown of MRs

More information can be found here: #216134 (comment 354619867)

This is MR 3 of 5 to fully implement and replace the Geo Settings Form from HAML -> Vue

Screenshots

Data Fetching Works: Screen_Shot_2020-06-23_at_2.06.07_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading