Skip to content

Disable sidekiq retries for Project/Group Import/Export

What does this MR do?

This MR disables sidekiq job retries for Project/Group Import/Export jobs in order to fail faster. After looking and Kibana logs it suggests that retries do not usually help. If it fails, it consistently fails and there is no need to do 5 retries of the same job. Data below. Max time frame I can grab data from Kibana is only 7 days.

Import

Project Import (class: RepositoryImportWorker)

  1. 2347 entries with retry_count > 0 & job_status: start
  2. 2263 entries with retry_count > 0 & job_status: fail
  3. 84 entries with retry_count > 0 & job_status: done

3.5% success rate.

RepositoryImportWorker is also used to create projects using templates, but it does not look like retries help or needed in this case (since 3.5% success rate it quite low).

Group Import (class: GroupImportWorker)

  1. 0 entries with retry_count > 0 & job_status: start
  2. 0 entries with retry_count > 0 & job_status: fail
  3. 0 entries with retry_count > 0 & job_status: done

No data. Group Import/Export jobs are fairly quick and wouldn't impact wait times as much but I would say that the same would happen to Groups Import/Export, if it fails, sidekiq retry wouldn't help.

Export

Project Export

  1. 185 entries with retry_count > 0 & job_status: start
  2. 144 entries with retry_count > 0 & job_status: fail
  3. 6 entries with retry_count > 0 & job_status: done

3.2% success rate.

Group Export

  1. 0 entries with retry_count > 0 & job_status: start
  2. 0 entries with retry_count > 0 & job_status: fail
  3. 0 entries with retry_count > 0 & job_status: done

No data.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading