Skip to content

Remove read_environment check for deployments

Ryan Cobb requested to merge rc/fix_public_dashboard_deployments into master

What does this MR do?

Fixes #219146 (closed)

For a public dashboard, the deployments endpoint was returning a 404 because an anonymous user doesn't have the :read_environment ability. This was removed in !32422 (merged)

Since the deployments controller only displays deployment info and is protected via the :read_deployment ability, I think we should be okay remove the :read_environment ability as in this MR.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading