Use FLOAT_TYPE for storage limit
What does this MR do?
Use FLOAT_TYPE for storage limit
INT would not be enough to the cover storage limits we are dealing with since it's send in bytes. It also gets stored as bigint in the database.
We're using FLOAT_TYPE here since BIG_INT is not exposed as a type in our GraphQL lib at this time and it would require us to convert it to a string since INT bigger than 32 bit are not supported: https://spec.graphql.org/June2018/#sec-Int. We also use FLOAT for our other storage size types: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/types/root_storage_statistics_type.rb
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular