Skip to content

Fix Spring Reloading of Gitlab::Metrics::Methods

Brett Walker requested to merge bw-fix-metrics-reload into master

What does this MR do?

Similar to !31512 (merged), many times I get the error

ArgumentError - A copy of Gitlab::Metrics::Methods has been removed from the module tree but is still active!:

while using spring and code gets reloaded.

As noted in the other MR, prefixing all the classes and modules here with :: seems to fix the issue.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports

Loading