Skip to content

Update 5_package tests to use outer describe

Dan Davison requested to merge qa-no-monkey-patching-5_package into master

What does this MR do?

Continuation of #220018 (closed) for QA Rel: https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/550

In RSpec 4.0 its monkey patching will be disabled by default, which means the describe, context, and other methods won't be available globally anymore.

https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

The unit/integration spec files have already been updated: #220018 (closed) (closed) Some of the docs have been updated, and the rest will be too: #220218 (closed) (closed) We use an outer context block in the E2E tests. We should change that to RSpec.describe, to be consistent with all the other spec files, and we should update our docs (including the beginner's guide).

Does this MR meet the acceptance criteria?

Conformity

Merge request reports

Loading