Skip to content

Prevent autosave when reply comment via cmd+enter

Samantha Ming requested to merge 216631-cmd-enter-no-clear-comment-text into master

What does this MR do?

When the user submits a reply to a comment with cmd + enter, it will trigger an autosave of the comment. Which then if the user trigger another reply, it will display the comment from the previous comment due to the autosave. The reason this was happening is because the "keydown" of cmd or enter triggers the input event, which is what triggers the autosave. In this MR, we fix this issue by stopping the autosave from happening when the user triggers the cmd + enter event.

Bug Fix
cmd+enter+working

Testing Case

  1. Go to an Issue (Repository > Issues > Select an issue)
  2. Write a comment and select "Start thread"

_

  1. Click on the "Reply..." bar to write a response
  2. Write any comment and submit using your keyboard cmd + enter
  3. Click on the "Reply..." bar to trigger another comment response.
  • It should be blank and look like this:

_

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #216631 (closed)

Edited by Samantha Ming

Merge request reports

Loading