Prevent autosave when reply comment via cmd+enter
What does this MR do?
When the user submits a reply to a comment with cmd + enter
, it will trigger an autosave of the comment. Which then if the user trigger another reply, it will display the comment from the previous comment due to the autosave. The reason this was happening is because the "keydown" of cmd
or enter
triggers the input
event, which is what triggers the autosave. In this MR, we fix this issue by stopping the autosave from happening when the user triggers the cmd + enter
event.
Bug | Fix |
---|---|
cmd+enter+working |
Testing Case
- Go to an Issue (Repository > Issues > Select an issue)
- Write a comment and select "Start thread"
- Click on the "Reply..." bar to write a response
- Write any comment and submit using your keyboard
cmd + enter
- Click on the "Reply..." bar to trigger another comment response.
-
It should be blank and look like this:
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #216631 (closed)
Edited by Samantha Ming