Remove dead endpoint EE::Clusters::ClustersController#metrics
requested to merge mwaw/208224-move-cluster-health-into-gitlab-core-remove-metrics-endpoint-from-cluster into master
What does this MR do?
During work at #208224 (closed) I've noticed possibly dead code
It looks like #metrics
endpoint in ee/app/controllers/ee/clusters/clusters_controller.rb
is no longer in use. From what I managed to track from repo history it was used to fetch additional metrics. It is passed to vue compenent here b4573bd8 and it is later used by 871bf96c but it not used any more, so instead of moving it to core, we can remove it for codebase.
Endpoint was added gitlab-foss!17139 (5db198fd)
Issue: #225869 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Mikołaj Wawrzyniak