Skip to content

Fix usage graph not exceeding 100%

Nicolas Dular requested to merge nicolas/fix-usage-graph-overflow into master

What does this MR do?

There was a bug report for the usage graph that it exceeded 100% and therefore caused an undesired behaviour: https://gitlab.com/gitlab-org/gitlab/-/issues/223030#note_370302384

This was caused by using toFixed which is unfortunately rounding the number. To prevent rounding errors, we are no longer rounding or truncating the ratio. We now also use flex instead of width.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports

Loading