Include SSL_CERT_DIR in gitlab-shell call
What does this MR do?
This MR ensures when the SSH authorized_keys
file has a new key added, the key command is prefixed with SSL_CERT_DIR=<dir>
if the SSL_CERT_DIR
env var has been provided to the Rails app.
command="SSL_CERT_DIR=/tmp/certs <gdk-root>/gitlab-shell/bin/gitlab-shell key-21",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa <ssh_public_key>
Related:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Ash McKenzie