Skip to content

Geo Settings Form - Remove Old Code

Zack Cuddy requested to merge 216134_05-geo-settings-remove-old into master

What does this MR do?

Closes #216134 (closed)

This MR is an attempt at MVC to avoid the above massive MR going in all at once.

This MR removes the feature flag :enable_geo_settings_form_js

This MR removes the need for a feature flag and removes the old HAML form. Essentially this is just removing all the old code and activating the new form in JavaScript for everyone.

Breakdown of MRs

More information can be found here: #216134 (comment 354619867)

This is MR 5 of 5 to fully implement and replace the Geo Settings Form from HAML -> Vue

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading