Skip to content

Use server-defined icon for alert system notes

Sarah Yasonik requested to merge sy-expose-icon-name into master

What does this MR do?

  • Adds a field through the GraphQL api which exposes the sprite name needed for rendering system notes
  • Fetches new field from FE
  • Uses new icon name reference from Alert detail view

Related issue: #213917 (closed)

Sibling MR: !35467 (merged)

  • If this MR should merge before !35467 (merged), there is no user-facing change and no changelog should be considered necessary

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading