Skip to content

Implement token selector for "Restrict access by IP address" field

What does this MR do?

See #220858 (closed)

This builds on top of !35543 (merged) to implement the GitLab UI Token selector component for the "Restrict access by IP address" field.

Screenshots

Before After
Screen_Shot_2020-07-08_at_10.46.35_AM Screen_Shot_2020-07-09_at_11.03.54_AM
Screen_Shot_2020-07-08_at_10.42.17_AM Screen_Shot_2020-07-09_at_11.05.17_AM

Local Testing

  1. Install a GitLab Silver License
  2. Create a new group
  3. Navigate to your group -> "Settings" -> "General" -> "Permissions, LFS, 2FA"

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Andrew Fontaine

Merge request reports

Loading