Skip to content

Add font awesome custom renderer

Derek Knox requested to merge 221083-custom-renderer-font-awesome into master

What does this MR do?

It ensures that inline html font awesome within a markdown file isn't editable in WYSIWYG mode. This was left has HTML vs. plain text intentionally but we can later go that route if desired. From a UX lens we could:

  1. convert to plain text instead
  2. load the used font awesome icons and render them (and/or make a dedicated editor for users, YAGNI for now)

Screenshots

Before After
Screen_Shot_2020-07-08_at_11.59.32_AM Screen_Shot_2020-07-08_at_11.10.23_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #221083 (closed)

Edited by Derek Knox

Merge request reports

Loading