Audit changes to project approval groups
What does this MR do?
Audit changes to approval group on project approval rule.
Relates to #213603 (closed)
Implementation approach
We wrap the rule.update
in a ::Gitlab::Audit::Auditor
which captures the initial audit context (i.e. author
, scope
, target
, ip_address
) object that are available at the time the operation is initiated.
Extra instrumentation is required in the interacted classes in the chain with Auditable
mixin to record audit event to the Audit Event queue via ::Gitlab::Audit::EventQueue
.
The EventQueue
are stored in Thread
via SafeRequestStore
and then later extracted when we record an audit event in ::Gitlab::Audit::Auditor
via AuditEventService
.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team