Skip to content

Resolve "Display non-markdown content in the WYSIWYG mode of the SSE::Identifiers (inline instance)"

Derek Knox requested to merge 227095-custom-renderer-identifiers-instances into master

What does this MR do?

It prevents editing of inline identifier instance syntax in the Static Site Editor's WYSIWYG mode.

Use case examples:
- Majority: two bracket pairs, back-to-back, each with content (including spaces)
  - `[environment terraform plans][terraform]`
  - `[an issue labelled `~"master:broken"`][broken-master-issues]`
- Minority: two bracket pairs the latter being empty or only one pair with content (including spaces)
  - `[this link][]`
  - `[this link]`

In a follow-up I'll be handling the unique case where inline code in the content section is possible.

In iteration, I can envision:

  • Our link button capable of handling these identifier links
  • Dedicated support for a UI for selecting existing or adding new identifiers
  • Rendering the actual link akin to the markdown link syntax `content

Screenshots

span solution (incomplete):

WYSIWYG (span) Markdown (span)
Screen_Shot_2020-07-13_at_9.57.51_AM Screen_Shot_2020-07-13_at_9.58.01_AM

a solution (complete):

WYSIWYG (a) Markdown (a)
Screen_Shot_2020-07-13_at_9.57.18_AM Screen_Shot_2020-07-13_at_9.57.29_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Derek Knox

Merge request reports

Loading