Skip to content

Fix issuables list search filter on labels

Scott Stern requested to merge ss/fix-issuables-list-label-not-search into master

What does this MR do?

Repro:

  • rails c
  • Feature.enable(:vue_issuables_list)
  • Go to project issues
  • Filter labels and milestones by using !=.

As a result of adding Vue Issuables List to projects, a lot of specs failed and the FF was turned off in the following specs. When trying to turn on specs for:

  • spec/features/issues/filtered_search/filter_issues_spec.rb
  • spec/features/projects/labels/issues_sorted_by_priority_spec.rb

I noticed that the api call for vue issuables list was using deprecated params when calling the api, breaking some existing functionality. This MR resolves a few of the specs we needed to and fixes the params issue.

Screenshots

Before

Screen_Shot_2020-07-10_at_3.35.07_PM

After

2020-07-10_15.29.33

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Scott Stern

Merge request reports

Loading