Avoid 500 errors with long expiration dates in tokens (!36657) · Merge requests · GitLab.org / GitLab

Stan Hu requested to merge sh-handle-distant-pat-expiry into master Jul 12, 2020

If a user created a personal access token with an expiration date far in advance, the date would be saved but a 500 error would be shown on display:

PG::DatetimeFieldOverflow: ERROR:  date out of range for timestamp

To fix this, since we're comparing dates, we shouldn't use NOW in the SQL query. Instead, we use CURRENT_DATE.

Edited Jul 12, 2020 by Stan Hu

Avoid 500 errors with long expiration dates in tokens