Skip to content

Add MR approval status to MR compliance entity

Robert Hunt requested to merge 217939-add-mr-approval-settings-to-mr-entity into master

What does this MR do?

As part of the work for #217939 (closed) we need to surface the approval status to the frontend.

This MR adds the approval status checks to the MR compliance entity which is then given to the dashboard via JSON.

The checks are:

  • MR authors are not allowed to approve MRs
  • MR committers are not allowed to approve MRs
  • The number of required approvers is >= 2

:success means that all of the above are true

:warning means that some of the above are true

:failed means that none of the above are true

Conformity

Availability and Testing

  1. Navigate to groups/[GROUP]/-/security/compliance_dashboard
  2. Use the Vue pane in your dev tools if you have it and check the ComplianceDashboard components mergeRequests property
  3. Alternatively you can use view source and check for instances of approval_status

Related #217939 (closed)

Edited by Robert Hunt

Merge request reports

Loading