Skip to content

Geo - Clean Up Geo Node Actions

Zack Cuddy requested to merge 11133-fix-icon-misalignment into master

What does this MR do?

Closes #11133 (closed)
Closes #219881 (closed)
Some more test cleanup for #211953 (closed)

This change is focused on cleaning up the Geo Node Actions Component. The most significant reason of this change was to fix the alignment issue on the Open Projects button. However, I took this time to go ahead and remove the technical debt from the component and spec.

I added some comments inline with the code to explain the changes.

Screenshots

Desktop Mobile
before Before_-_Desktop Before_-_Mobile
after New_-_Desktop New_-_Mobile

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #11133 (closed)

Edited by Zack Cuddy

Merge request reports

Loading