Skip to content

Removes extra Secret-Detection job when opening a merge request

Zach Rice requested to merge secret-detection-remove-extra-job into master

What does this MR do?

Fixes issue brought up by @dstull here. The problem was the rule defined here kicks off a detached pipeline when opening a merge request. To fix this all we need to do is check if the $CI_COMMIT_BRANCH exists.

Demo of this working: zrice/demo-historic-secrets!9 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zach Rice

Merge request reports

Loading