Skip to content

Add include_parent_milestones to milestones API

Eugenia Grieff requested to merge 196066-add-milestone-expired-info-be-2 into master

What does this MR do?

Related to #196066 (closed)

Introduces a new param include_parent_milestones for project milestones API endpoint GET /projects/:id/milestones.

The default value for this param is false and when set to true, the request will additionally fetch milestones from the project's parent group and descendants.

This change is a requirement for milestones dropdown with expired milestones and addresses the following point in this discussion:

  1. The public API doesn't support fetching milestones for a project and its parent group(s) in one request, unlike the internal API we were already using: !35595 (comment 376337178)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Eugenia Grieff

Merge request reports

Loading