Skip to content

Extract GitLab::Ci::Build::AutoRetry class

Allison Browne requested to merge 35237-extract-ci-build-autoretry-class into master

What does this MR do?

This is a pure refactor(i.e. no behavior is expected to change)

Extracts auto retry logic out of the build model.

Adds a new Gitlab::Ci::Build::AutoRetry class with and allowed? method that is called from the ci build model.

Relates to #35237 (closed)

Screenshots

header ci config jobs failure reason
retry Screen_Shot_2020-07-16_at_2.03.29_PM Screen_Shot_2020-07-16_at_2.02.18_PM Screen_Shot_2020-07-16_at_2.14.33_PM
retry with max/when Screen_Shot_2020-07-16_at_2.19.19_PM Screen_Shot_2020-07-16_at_2.17.44_PM Screen_Shot_2020-07-16_at_2.17.53_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Allison Browne

Merge request reports

Loading