Skip to content

WIP: Add JSON schema validations for metrics dashboard

Ryan Cobb requested to merge rc/add_custom_dashboard_validator_2 into master

What does this MR do?

In support of #28241 (closed)

This is a second attempt at using JSON schema to validate metrics dashboard schema. See comments in changes for a bit more info on how it works.

Looking for feedback from the team. If we are in agreement I'll go ahead and build out the rest + specs.

@mikolaj_wawrzyniak @rpereira2 (@splattael since you seem to continue to be tagged in these conversations 😄)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ryan Cobb

Merge request reports

Loading