Skip to content

Refactor TestReportSummary with total

Max Orefice requested to merge mo-refactor-test-report-summary into master

Ref: #223240 (closed)

What does this MR do?

This MR refactors our TestReportSummary API.

It includes the following items:

  • Refactor TestReportSummaryEntity to expose all counter data through a new hash
  • Rename some variables to better express what the actual data is
  • Get rid of useless attr_accessor not being used outside of the class

This MR does not implement this refactor for a TestSuiteSummary, this will be tackled in a follow up MR

Why are we doing this?

We want to unify our data structure returned by our API. This way we encapsulate everything within a new total hash to simplify our codebase.

Screenshots

Endpoint JSON response
Before Mozilla_Firefox_2020-07-16_15-48-18
After Mozilla_Firefox_2020-07-16_15-51-15

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports

Loading