Skip to content

Remove extraneous br tags via formatter

Derek Knox requested to merge 227602-duplicate-br-tags into master

What does this MR do?

It removes extraneous <br> tags via an added (and optional) formatter in the rich_content_editor.

I can envision us (SSE) extending the formatter to additionally cleanup duplicate empty lines, adding a new line at the end of a file, and any other formatting enforcement we want in the SSE. However the FE may not be the place to do this long term, but this current solution at least alleviates the extra <br> tags introduced by the Squire editor of Toast UI editor while introducing an abstraction for us to iterate on.

Screenshots

Before After
Screen_Shot_2020-07-17_at_8.58.34_AM Screen_Shot_2020-07-17_at_8.59.02_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #227602 (closed)

Edited by Derek Knox

Merge request reports

Loading