Remove extraneous br tags via formatter
What does this MR do?
It removes extraneous <br>
tags via an added (and optional) formatter
in the rich_content_editor
.
I can envision us (SSE) extending the formatter
to additionally cleanup duplicate empty lines, adding a new line at the end of a file, and any other formatting enforcement we want in the SSE. However the FE may not be the place to do this long term, but this current solution at least alleviates the extra <br>
tags introduced by the Squire editor of Toast UI editor while introducing an abstraction for us to iterate on.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #227602 (closed)
Edited by Derek Knox