Skip to content

Follow up: Move compliance dashboard statuses to new component

Robert Hunt requested to merge follow-up-move-statuses-to-new-component into master

What does this MR do?

The current status implementation reuses a lot of markup between the two statuses that exist. This MR adds a new wrapping Status component to normalise and consolidate the statuses. We then have two separate sub-components to handle the nuances between the two.

This should have no visual differentiation between the current and new implementation and is purely an improvement on the existing code.

Screenshots

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Visit [GDK/GITLAB HOST]/groups/gitlab-org/-/security/compliance_dashboard and confirm the status icons are shown with tooltips.

Note: If you don't have any MR's appearing in your local Compliance dashboard, you can run bundle exec rake db:seed_fu FILTER=compliance_dashboard_merge_requests to populate some for you 🙂

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert Hunt

Merge request reports

Loading