Follow up: Move compliance dashboard statuses to new component
What does this MR do?
The current status implementation reuses a lot of markup between the two statuses that exist. This MR adds a new wrapping Status
component to normalise and consolidate the statuses. We then have two separate sub-components to handle the nuances between the two.
This should have no visual differentiation between the current and new implementation and is purely an improvement on the existing code.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
Visit [GDK/GITLAB HOST]/groups/gitlab-org/-/security/compliance_dashboard
and confirm the status icons are shown with tooltips.
Note: If you don't have any MR's appearing in your local Compliance dashboard, you can run bundle exec rake db:seed_fu FILTER=compliance_dashboard_merge_requests
to populate some for you
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team