Skip to content

WIP: Add the Install GitLab Runner popup window

Luiz Felipe Fontes Botelho requested to merge ciandt_dev/gitlab:add-modal-install-runner into master

What does this MR do?

Create a modal on the Group CI/CD Runner Settings to view the download and install instructions for each environment and architecture defined on the service !35364 (merged)

Are there points in the code the reviewer needs to double check?

  • Check the necessity of the feature toggle implementation in more points and if it's implemented correctly
  • The layout is the same as the design, but doesn't hurt to double check
  • Discuss the labeling on the environments and architectures, since as of now, they are raw, being the same values as the backend expects which might not be so intuitive for the user

Dependencies

This MR depends on !35364 (merged)

Does this MR meet the acceptance criteria?

  • Documentation created/updated - Create Changelog
  • Added tests for this feature/bug
  • In case of conflicts with master - no conflicts

What are the relevant issue numbers?

#214587 (closed)

Edited by Adrien Kohlbecker

Merge request reports