Skip to content

9470 - Possible fix for not producing audit events by failed login by ldap users

What does this MR do?

It's just a simple call to log_failed_login implemented in OmniauthCallbacksController

    def log_failed_login(author, provider)
      ::AuditEventService.new(author,
                            nil,
                            ip_address: request.remote_ip,
                            with: provider)
          .for_failed_login.unauth_security_event
    end

corresponding defect #9470 (closed) by @stanhu

corresponding enterprise customer issue: https://support.gitlab.com/hc/en-us/requests/164607?page=1

Screenshots

expected audit event would be something like this:

{
"id": 9,
"author_id": -1,
"entity_id": -1,
"entity_type": "User",
"details": {
"failed_login": "STANDARD",
"author_name": "root",
"target_details": "root",
"ip_address": "10.159.160.183",
"entity_path": null
},
"created_at": "2020-07-16T12:48:32.765Z"
},

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Petar

Merge request reports

Loading