Don't disable LFS when repo access is disabled in project settings
What does this MR do?
Issue: #229575 (closed)
LFS should be allowed to be enabled even when repository access is not. From #229575 (closed):
LFS is disabled, which also breaks the Design Management feature because it uses LFS exclusively for storage.
This MR removes the force-disabling of LFS when repo access is disabled. This means LFS can be enabled, even when Repository is disabled.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk