Split "Test settings" and "Save changes" buttons [RUN AS-IF-FOSS]
What does this MR do?
Issue #197297 (closed): Split "Test settings" and "Save changes" to separate buttons
- Add
isSaving
andisTesting
to store to use for separate buttons. - Use Vue toast to display messages instead of old flash messages.
- Move whole bottom bar (action buttons - including "Cancel") to Vue.
- Update copy of all integration actions (mostly in backend).
Screenshots
Buttons before
Buttons after
Saved and active
Test successful
Test failed
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Justin Ho Tuan Duong