Update CREATE TRIGGER syntax to use EXECUTE FUNCTION
What does this MR do?
Change occurrences of CREATE TRIGGER ... EXECUTE PROCEDURE
to CREATE TRIGGER ... EXECUTE FUNCTION
. The PROCEDURE
keyword was the previous required syntax on PG9.6, but as of PG11 is deprecated. In PG12, internal PG metadata use the FUNCTION
keyword, so we should use that as well to be consistent.
See the linked issue for details: #227089 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Bair