Fix Any filter for labels in Value Stream Analytics
What does this MR do?
This MR fixes the following error when Any
label is selected in the filter:
PG::InvalidColumnReference: ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list LINE
When the query contains DISTINCT
, the columns referenced in the ORDER BY
clause should be present in the SELECT
.
Steps to reproduce:
- Seed your dev environment
- Seed VSA:
FILTER=cycle_analytics SEED_CYCLE_ANALYTICS=1 bundle exec rake db:seed_fu
- Enable the
value_stream_analytics_filter_bar
feature flag. - Navigate to the created group / analytics / value stream
- Filter for labels, select
Any
- Error should show up in the logs (
InvalidColumnReference
)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Stan Hu