Skip to content

Update QA E2E selector for close token icon

Peter Hegman requested to merge update-e2e-test-icon-selector into master

What does this MR do?

See gitlab-ui#887 (closed)

Changes the a selector used in an E2E test to use the data-testid selector instead of a CSS class. This should help prevent any flakiness down the road as the data-testid attribute in GitLab UI shouldn't change but it is possible .gl-token-close could change at some point.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading