Skip to content

Fix typo in Sidekiq memory killer document

Qingyu Zhao requested to merge fix-typo-sidekiq-memory-killer-document into master

Fix typo in the Sidekiq memory killer document.

The forceful termination wait time should be Sidekiq.options[:timeout] + 2, not Sidekiq.options[:timeout] * 2.

Refer to code https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/sidekiq_middleware/memory_killer.rb#L50:

wait_and_signal_pgroup(Sidekiq.options[:timeout] + 2, 'SIGKILL', 'die')

and code https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/sidekiq_daemon/memory_killer.rb#L119

signal_and_wait(Sidekiq.options[:timeout] + 2, 'SIGTERM', 'gracefully shut down')

Merge request reports