Draft: Make time range in metrics dashboard behave like in an SPA
What does this MR do?
Part of: #218494 (closed)
Our dashboard would refresh the entire page whenever users would change the time range, with this change we can update the page data.
Please also see #229709 (closed), this MR is an implementation on how to make our dashboards more like a single page application.
Technical Implementation
- Previously, our dashboard would trigger fetching the initial data with the given time range, now that responsibility is passed to the Page that contains it.
- All components that access the store can access the time range same as before.
- The query parameters in the browser bar get updated when time range is updated.
Screenshots
Please note we don't refresh the page:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon