Skip to content

Remove upcoming database deprecation warning

Mitchell Nielsen requested to merge remove-upcoming-db-deprecation-warning into master

What does this MR do?

Per omnibus-gitlab#5499 (comment 387685215), this MR removes the upcoming database deprecation notice in favor of only displaying a message if the current database version minimum is not met.

Context: pros/cons of upcoming deprecation feature

  • Pros:
    • Provides admins with advanced notice that is tailored to their specific version of the database
  • Cons:
    • Can cause confusion to admins as the message looks very similar to the warning that the current database version requirement is not met (as opposed to the upcoming requirement)
    • Adds to the list of places to keep track of (and update) version information
    • Message will re-appear upon each load of the admin UI, even if the user previously dismissed the notice

Given the cons listed above, this MR proposes removing this feature pending feedback from the team.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mitchell Nielsen

Merge request reports

Loading