Skip to content

Add workaround for Chrome/Edge 84 SVG bug

Lukas Eipert requested to merge leipert-cache-busting-icons into master

What does this MR do?

Chrome and Edge 84 have a bug relating to icon sprite svgs https://bugs.chromium.org/p/chromium/issues/detail?id=1107442

If the SVG is loaded, under certain circumstances the icons are not shown. As a workaround we use the well-tested svg4everybody and forcefully include the icon fragments into the DOM and thus circumventing the bug.

Screenshots

In order to demonstrate that the core of the function works:

Kapture_2020-07-31_at_15.43.23

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports

Loading