Add Google Tag Manager to sign in/up and trial pages
What does this MR do?
Part of #223768 (closed)
MR for adding the config to omnibus: omnibus-gitlab!4473 (merged)
This adds the google tag manager scripts. They only get activated
when google_tag_manager_id
is set in the config.
They got added to analyze the sign in, sign up and trial flows of
GitLab. To minimize the amount of JS we load, we only activate
the google tag manager on the sign in/sign up and the trial flow
pages:
-
https://gitlab.com/-/trials/new -
https://gitlab.com/-/trial_registrations/new -
https://gitlab.com/-/trials/select -
https://gitlab.com/users/sign_in -
https://gitlab.com/users/sign_up
Guide about embedding google tag manager.
After merging: There needs to be a follow-up issue for infrastructure to add the analytics ID from the issue to our config and roll it out.
Screenshots
Requests | Header embed | iFrame |
---|---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #223768 (closed)